Fix bug where a default config setting wouldn't show the key you were using #388

Merged

Vylpes merged 1 commit from feature/289-config-get-bug into develop

2023-12-22 14:36:36 +00:00

Vylpes commented

2023-12-18 13:40:30 +00:00

Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fix bug where a default config setting wouldn't show the key you were using
Fix bug where a config which doesn't exist wouldn't show the key you were using

#289

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

This was tested by checking both a setting which is defaulted and not used, and both now show they key correctly

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that provde my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Fix bug where a default config setting wouldn't show the key you were using - Fix bug where a config which doesn't exist wouldn't show the key you were using #289 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. - This was tested by checking both a setting which is defaulted and not used, and both now show they key correctly # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules

Vylpes added 1 commit 2023-12-18 13:40:30 +00:00

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

1385670135 Fix bug where a default config setting wouldn't show the key you were using

Vylpes requested review from VylpesTester 2023-12-18 13:40:33 +00:00

Vylpes added the