Fix invalid config value not showing properly #336

Merged
Vylpes merged 5 commits from feature/315-config-value-undefined into develop 2023-09-29 18:00:29 +01:00
Owner

Description

  • Fix the invalid config value not showing properly
  • When there is no server value or default value, it will show it as <NONE>

#315

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description - Fix the invalid config value not showing properly - When there is no server value or default value, it will show it as `<NONE>` #315 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. # Checklist - [x] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2023-08-16 16:20:10 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
fa4236d8a1
Fix invalid config value not showing properly
Vylpes requested review from VylpesTester 2023-08-16 16:21:35 +01:00
Vylpes added the
type
bug
label 2023-08-16 16:21:40 +01:00
Vylpes added this to the 3.2 milestone 2023-08-16 16:21:44 +01:00
VylpesTester was assigned by Vylpes 2023-08-16 16:21:48 +01:00
VylpesTester requested changes 2023-08-18 21:08:27 +01:00
VylpesTester left a comment
Member

Need to fix the conflicts

Need to fix the conflicts
VylpesTester added spent time 2023-08-18 21:08:37 +01:00
5 minutes
Vylpes added 1 commit 2023-09-29 11:43:49 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
99c889b82c
Merge branch 'develop' into feature/315-config-value-undefined
Vylpes added 1 commit 2023-09-29 11:45:40 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
4d07a0f4e0
Temporarily disable test scripts until we fix the tests
Vylpes added 1 commit 2023-09-29 11:57:09 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
d7a949da40
Add DNS settings to ci
Vylpes added 1 commit 2023-09-29 11:57:48 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is passing
16f7579898
Revert "Add DNS settings to ci"
This reverts commit d7a949da40.
Vylpes requested review from VylpesTester 2023-09-29 12:09:17 +01:00
VylpesTester approved these changes 2023-09-29 18:00:07 +01:00
VylpesTester added spent time 2023-09-29 18:00:13 +01:00
5 minutes
Vylpes merged commit 2d51b83d77 into develop 2023-09-29 18:00:29 +01:00
Vylpes deleted branch feature/315-config-value-undefined 2023-09-29 18:00:29 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 10 minutes
VylpesTester
10 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#336
No description provided.