Fix config get command not returning the right key value name #334

Merged
Vylpes merged 1 commit from feature/289-config-name into develop 2023-08-18 21:04:07 +01:00
Owner

Description

  • Fixed the /config get command not returning the actual key's name, instead using a strinified "Object" property

#289

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • This was tested by running the /config get command on my dev bot, and making sure it still gets the correct value for the key string

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provide my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description - Fixed the `/config get` command not returning the actual key's name, instead using a strinified "Object" property #289 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? - This was tested by running the `/config get` command on my dev bot, and making sure it still gets the correct value for the key string # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that provide my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2023-08-14 17:20:59 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
d8732491c4
Fix config get command not returning the right key value name
Vylpes requested review from VylpesTester 2023-08-14 17:21:09 +01:00
Vylpes added the
type
bug
label 2023-08-14 17:21:16 +01:00
Vylpes added this to the 3.2 milestone 2023-08-14 17:21:18 +01:00
VylpesTester was assigned by Vylpes 2023-08-14 17:21:22 +01:00
VylpesTester approved these changes 2023-08-18 21:03:49 +01:00
Vylpes merged commit 1c4fdd05f1 into develop 2023-08-18 21:04:07 +01:00
Vylpes deleted branch feature/289-config-name 2023-08-18 21:04:07 +01:00
VylpesTester added spent time 2023-08-18 21:04:17 +01:00
5 minutes
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 5 minutes
VylpesTester
5 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#334
No description provided.