RabbitLabs/vylbot-app
RabbitLabs/vylbot-app
4
0
Fork 0
Code Issues 107 Pull requests 5 Actions Packages Projects 1 Releases 21 Wiki Activity

Switch to TypeORM's DataSource API #299

Merged
Vylpes merged 5 commits from feature/297-stage-deployment into develop 2023-05-26 17:59:22 +01:00
Conversation 0 Commits 5 Files changed 37 +128 -164
Vylpes commented 2023-05-17 18:49:38 +01:00
Owner
Copy link
  • Switch to TypeORM's DataSource API, rather than using the now deprecated ormconfig.json
  • This will fix stage deployment not knowing how to deploy the database migrations

#297

NOTE: This change requires the deployment scripts to be updated, please update them on the server before merging

- Switch to TypeORM's DataSource API, rather than using the now deprecated ormconfig.json - This will fix stage deployment not knowing how to deploy the database migrations #297 > **NOTE:** This change requires the deployment scripts to be updated, please update them on the server before merging
Vylpes added 4 commits 2023-05-17 18:49:38 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
Details
9ebc8a8991 Switch to DataSource
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
818c527ab2 Update db:up yarn command
Vylpes requested review from VylpesTester 2023-05-17 18:49:44 +01:00
Vylpes added the
type
incident
 label 2023-05-17 18:49:54 +01:00
Vylpes added this to the 3.1 milestone 2023-05-17 18:49:59 +01:00
VylpesTester was assigned by Vylpes 2023-05-17 18:50:05 +01:00
VylpesTester requested changes 2023-05-20 15:17:19 +01:00
src/client/client.ts Outdated
@ -45,3 +45,1 @@
console.error(e);
return;
});
AppDataSource.initialize()
VylpesTester commented 2023-05-20 15:01:17 +01:00
Member
Copy link

I think this should be awaited, or at least put the rest of the function in the .then()

I think this should be awaited, or at least put the rest of the function in the .then()
Vylpes marked this conversation as resolved
Vylpes added 1 commit 2023-05-22 18:12:42 +01:00
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
90eeba834c Await datasource initialisation
Vylpes requested review from VylpesTester 2023-05-23 18:41:50 +01:00
VylpesTester approved these changes 2023-05-26 17:57:53 +01:00
Vylpes merged commit e6c845e3b2 into develop 2023-05-26 17:59:22 +01:00
Vylpes deleted branch feature/297-stage-deployment 2023-05-26 17:59:22 +01:00
VylpesTester added spent time 2023-05-27 14:29:49 +01:00
5 minutes
Vylpes removed this from the 3.1 milestone 2023-06-22 17:48:14 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
VylpesTester
Labels
Clear labels   
MankBot

   
PotatoBot

   
VylBot

   
blocked

   
commands

   
configuration

   
core

   
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
events

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
moderation

   
needs criteria

   
needs estimate

   
question

Further information is requested

  
rules
  
type
admin

  
type
bug
Something isn't working

  
type
defect
A task that has fallen out of testing

  
type
dependencies
Pull requests that update a dependency file

  
type
documentation
Improvements or additions to documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
type
subtask

  
wontfix

This will not be worked on

  
blocked

   
duplicate

   
needs criteria

   
needs estimate

   
question
  
type
admin

  
type
bug

  
type
defect

  
type
dependencies

  
type
design

  
type
documentation

  
type
epic

  
type
incident

  
type
investigation

  
type
spike

  
type
story

  
won't fix
No labels
MankBot
PotatoBot
VylBot
blocked
commands
configuration
core
duplicate
enhancement
events
good first issue
help wanted
invalid
moderation
needs criteria
needs estimate
question
rules
type
admin
type
bug
type
defect
type
dependencies
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
type
subtask
wontfix
blocked
duplicate
needs criteria
needs estimate
question
type
admin
type
bug
type
defect
type
dependencies
type
design
type
documentation
type
epic
type
incident
type
investigation
type
spike
type
story
won't fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
VylpesTester
2 participants
Notifications
Total time spent: 5 minutes
VylpesTester
5 minutes
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#299
No description provided.
Delete branch "feature/297-stage-deployment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?