Fix nickname change event not working #385

Merged
Vylpes merged 1 commit from feature/353-nicknane-update into develop 2023-12-16 16:50:27 +00:00
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Fix the nickname changed event not working
    • This was due to the default value not being set because of a typo
  • Update the client to allow partials for guild members

#353

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration.

  • This has been tested locally by making sure the nickname change event fires when expected

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that provde my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
# Description Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - Fix the nickname changed event not working - This was due to the default value not being set because of a typo - Update the client to allow partials for guild members #353 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # How Has This Been Tested? Please describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details to your test configuration. - This has been tested locally by making sure the nickname change event fires when expected # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that provde my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
Vylpes added 1 commit 2023-12-14 18:07:33 +00:00
Fix nickname change event not working
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
0fe7a649cd
Vylpes requested review from VylpesTester 2023-12-14 18:07:36 +00:00
Vylpes added the
type
bug
label 2023-12-14 18:07:41 +00:00
VylpesTester was assigned by Vylpes 2023-12-14 18:07:47 +00:00
VylpesTester approved these changes 2023-12-16 16:50:09 +00:00
VylpesTester added spent time 2023-12-16 16:50:14 +00:00
1 minute
Vylpes merged commit efb431ef3a into develop 2023-12-16 16:50:27 +00:00
Vylpes deleted branch feature/353-nicknane-update 2023-12-16 16:50:27 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 1 minute
VylpesTester
1 minute
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: RabbitLabs/vylbot-app#385
No description provided.